hey @WeihanLi , checking where the similar approach is applied and will try that. thanks !

where is this quote from?

This feature will be released in Redis 8.0 and is available since 7.2.5 in Valkey from my research

where is this quote from?

This feature will be released in Redis 8.0 and is available since 7.2.5 in Valkey from my research

From my research:
redis: redis/redis#12765

valkey:

• https://github.com/valkey-io/valkey/blob/unstable/src/commands/hscan.json
• https://github.com/valkey-io/valkey/blob/7.2.5/src/commands/hscan.json

double checked with valkey, not supported so far, 7.2.5 does not support this feature 😢

Supported with Redis 7.4

my 2 cents on this,,
making developers life easier and keeping client compatible in more situations/environments is cool.
on the other hand handling such scenarios and doing more (than actually needed/requested) under the hood, this introduces the possibility of significant increase in resource usage both on client and server side while people probably wont even get noticed about it (probably until something bad).
what do you think about it ?

hey @NickCraver, how about taking another look to this one?? Let me know if you have concerns or there are things to fix and i ll deal with it.

I noticed in updating this that we have a mismatch here on HashScanNoValues (2 overloads)vsHashScanNoValuesAsync` (1 method).

I'd ask when adding here: that's the purpose of the smaller overload for HashScanNoValues? It seems like we should just remove it and normalize on the one method, but maybe I'm missing a use case.

I'd ask when adding here: that's the purpose of the smaller overload for HashScanNoValues? It seems like we should just remove it and normalize on the one method, but maybe I'm missing a use case.

hey @NickCraver,, trying to remember my reasoning.. and after a quick look back to the code, you are most probably right.
I guess it was just the sake of keeping the convention and provide same method signatures with HashScan and HashScanAsync already there.
i dont have a strong opinion on it. What do you prefer ??

@atakavci Let's trim down and remove please - usually the #1 reason for overload is backwards compat, which isn't in play here :)

@atakavci Let's trim down and remove please - usually the #1 reason for overload is backwards compat, which isn't in play here :)

done 👍